Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added serial and status label to asset maintenances page and API #14264

Merged
merged 13 commits into from
Feb 14, 2024

Conversation

snipe
Copy link
Owner

@snipe snipe commented Feb 14, 2024

This adds the serial number of the asset and the status label to the asset maintenance page, and also better indicates maintenances on deleted assets, with support for sorting on both status label name and serial.

Screenshot 2024-02-14 at 10 01 12 AM Screenshot 2024-02-14 at 10 13 02 AM Screenshot 2024-02-14 at 10 13 11 AM Screenshot 2024-02-14 at 10 13 20 AM Screenshot 2024-02-14 at 10 13 48 AM Screenshot 2024-02-14 at 10 16 42 AM Screenshot 2024-02-14 at 10 16 52 AM

Copy link

This pull request has been linked to Shortcut Story #24816: Add serial, asset status to maintenances view.

Copy link

what-the-diff bot commented Feb 14, 2024

PR Summary

  • Added Serial and Status Label Attributes
    Serial and status label attributes were added to pertinent files (AssetMaintenancesController.php, AssetMaintenancesTransformer.php, AssetMaintenance.php and AssetMaintenancesPresenter.php). This means that these properties will now be visible, searchable, and sortable in the system, enhancing data manipulation.

  • Updated Data Table Layout
    Modifications were made to the AssetMaintenancesPresenter.php to include serial and status label columns in the data table layout. This enhances the way the data is presented to the user, increasing readability and comprehension.

  • Added New Translation String
    New translation string cannot_be_edited has been added in general.php, which means we have extended our tool's localization and it can now deliver that specific message in multiple languages.

  • Restrictive Logic for Edit Button Display
    In view.blade.php, additional logic was added to govern the display of the edit button. Now it only shows when an asset is not deleted, preventing accidental edits on deleted assets and improving the user interface experience.

  • Refined Asset Maintenance Loading
    In AssetMaintenancesController.php, the logic was refined to redirect if the asset associated with maintenance does not exist. This change aims at enhancing the system's stability and providing a better user experience by minimizing loading errors.

  • Typo Fix
    A minor typo fix was carried out in a comment in Asset.php. While this doesn't affect system functionality, it improves code readability and maintenance.

Copy link
Collaborator

@uberbrady uberbrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a great set of changes! I can definitely imagine when you're going through maintenances that knowing what serial number things are could be helpful - and knowing which things are supposed to be maintained but are actually soft-deleted - also very useful. Thank you!

@snipe snipe merged commit 88a84e9 into develop Feb 14, 2024
7 of 8 checks passed
@snipe snipe deleted the feature/sc-24816 branch February 14, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants